Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug message. #7749

Merged
merged 1 commit into from
Dec 28, 2019
Merged

Fix debug message. #7749

merged 1 commit into from
Dec 28, 2019

Conversation

iu0zjp2
Copy link
Contributor

@iu0zjp2 iu0zjp2 commented Dec 28, 2019

The [path] field of [Fingerprint] contains the "Hash of the path to the base source file".

repro:

$ cargo new a
$ cd a
$ echo 'cfg-if="0"' >> Cargo.toml
$ CARGO_HOME=cargo1 cargo build
$ mv cargo1 cargo2
$ CARGO_LOG=cargo::core::compiler::fingerprint=trace CARGO_HOME=cargo2 cargo build
[...]
[... INFO  cargo::core::compiler::fingerprint]     err: path to the compiler has changed

The [path] field of [Fingerprint] contains the "Hash of the path to the base source file".
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2019
@ehuss
Copy link
Contributor

ehuss commented Dec 28, 2019

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Dec 28, 2019

📌 Commit 1b70e57 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2019
@bors
Copy link
Collaborator

bors commented Dec 28, 2019

⌛ Testing commit 1b70e57 with merge 5336fba...

bors added a commit that referenced this pull request Dec 28, 2019
Fix debug message.

The [path] field of [Fingerprint] contains the "Hash of the path to the base source file".

repro:
```
$ cargo new a
$ cd a
$ echo 'cfg-if="0"' >> Cargo.toml
$ CARGO_HOME=cargo1 cargo build
$ mv cargo1 cargo2
$ CARGO_LOG=cargo::core::compiler::fingerprint=trace CARGO_HOME=cargo2 cargo build
[...]
[... INFO  cargo::core::compiler::fingerprint]     err: path to the compiler has changed
```
@bors
Copy link
Collaborator

bors commented Dec 28, 2019

☀️ Test successful - checks-azure
Approved by: ehuss
Pushing 5336fba to master...

@bors bors merged commit 1b70e57 into rust-lang:master Dec 28, 2019
bors added a commit to rust-lang/rust that referenced this pull request Jan 7, 2020
Update cargo

9 commits in 86134e7666a088682f20b76278c3ee096a315218..6e1ca924a67dd1ac89c33f294ef26b5c43b89168
2019-12-23 16:08:07 +0000 to 2020-01-06 19:11:37 +0000
- Fix dynamic linking for Windows UWP MSVC targets (rust-lang/cargo#7758)
- Fix CARGO_TARGET_triple_LINKER environment variable. (rust-lang/cargo#7763)
- Remove metadata dep_kinds duplicates. (rust-lang/cargo#7756)
- Check for a source defined multiple times. (rust-lang/cargo#7751)
- Fix typo. (rust-lang/cargo#7735)
- Fix config env vars that are prefix of another with underscore. (rust-lang/cargo#7748)
- Add test for `cargo pkgid` (rust-lang/cargo#7741)
- Add a note to the error message for using --feature / --no-default-features in a virtual workspace (rust-lang/cargo#7742)
- Fix debug message. (rust-lang/cargo#7749)
@ehuss ehuss added this to the 1.42.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants